Changeset 46116

Timestamp:

05/16/08 04:38:48 (2 months ago)

Author:

ronalfy

Message:

Attemping to fix Ie bugs. It seems anything under 1 1/2 minutes can't be edited.

Location:

wp-ajax-edit-comments/trunk/2.0/wp-ajax-edit-comments

Files:

• js/comment-editor.js.php (modified) (2 diffs)
• js/wp-ajax-edit-comments.js.php (modified) (4 diffs)
• wp-ajax-edit-comments.php (modified) (1 diff)

wp-ajax-edit-comments/trunk/2.0/wp-ajax-edit-comments/js/comment-editor.js.php

@@ -45 +45 @@
       $j("#comment-options").attr("class", cookieValue);
     }
+    
     //The "more options" button
       $j("#comment-options h3").bind("click", function() { 
@@ -76 +77 @@
     s.timeout = 30000;
       //Change the edit text and events
+    $j("#status").show();
     $j("#status").attr("class", "success");
-    $j("#message").html("<?php _e('Loading...', $WPrapAjaxEditComments->localizationName) ?>");
+  $j("#message").html("<?php _e('Loading...', $WPrapAjaxEditComments->localizationName) ?>");
       
     s.success = function(r) {

wp-ajax-edit-comments/trunk/2.0/wp-ajax-edit-comments/js/wp-ajax-edit-comments.js.php

@@ -85 +85 @@
       data.action = 'gettimeleft';
       data.success = function(r) {
-            if (r == "-1") {
-            minutes = 0;
-          seconds = 0;
-        } else if (r == "1") {
-            return;
-        }
             var res = wpAjax.parseAjaxResponse(r, data.response,data.element);
         jQuery.each( res.responses, function() {
-            //todo - check for errors
+            if (this.what == "error" || this.what == "success") {
+            return;
+          }
             if (this.what == "minutes") {
             minutes = parseInt(this.data);
@@ -115 +111 @@
   //Parameters - timer (obj with timer data)
   function get_time_left_timer(timer) {
+  //todo in ie6 and ie7, anything under minute and 1/2 can't be edited.
       clearTimeout(timers[timer.cid]);
     seconds = timer.seconds - 1;
@@ -120 +117 @@
     element = timer.element;
     //Check to see if the time has run out
-            if (minutes ==0 && seconds == 0) { 
+            if (minutes <=0 && seconds <= 0) { 
                   $j("#edit" + timer.cid).unbind();
       element.remove();
@@ -142 +139 @@
       //This try statement is for the iFrame
       if (document.getElementById('TB_iframeContent') != undefined) {
+            //todo - does not work in ie
         $j("#timer" + timer.cid, document.getElementById('TB_iframeContent').contentDocument).html("&nbsp;(" + text + ")");;
       }

wp-ajax-edit-comments/trunk/2.0/wp-ajax-edit-comments/wp-ajax-edit-comments.php

@@ -546 +546 @@
                   //Get the Timestamp
                   $comment = $wpdb->get_row($query, ARRAY_A);
-                  if (!$comment) { return "-1"; }
+                  if (!$comment) { 
+                        $response->add( array(
+                              'what' => 'error',
+                              'id' => $commentID,
+                              'data' => "-1"
+                        ));
+                        $response->send();
+                  }
                   if ($this->can_indefinitely_edit($comment['user_id'])) {    
-                  return "1";
+                        $response->add( array(
+                              'what' => 'success',
+                              'id' => $commentID,
+                              'data' => "1"
+                        ));               
                   }
                   //Get the time elapsed since making the comment