Changeset 9327

Timestamp:

03/23/07 19:50:17 (1 year ago)

Author:

gallir

Message:

Version 2.1.1 Security fix.

Files:

• wp-cache/tags/release-2.1.1 (copied) (copied from wp-cache/trunk)
• wp-cache/tags/release-2.1.1/wp-cache-phase2.php (copied) (copied from wp-cache/trunk/wp-cache-phase2.php)
• wp-cache/tags/release-2.1.1/wp-cache.php (copied) (copied from wp-cache/trunk/wp-cache.php) (17 diffs)
• wp-cache/trunk/wp-cache.php (modified) (17 diffs)

wp-cache/tags/release-2.1.1/wp-cache.php

@@ -4 +4 @@
-Plugin URI: http://mnm.uib.es/gallir/wp-cache-2/
-Description: Very fast cache module. It's composed of several modules, this plugin can configure and manage the whole system. Once enabled, go to "Options" and select "WP-Cache".
-
+.1
-Author: Ricardo Galli Granada
-Author URI: http://mnm.uib.es/gallir/
@@ -26 +26 @@
-
-/* Changelog
+      2007-03-23
+            - Version 2.1.1: Patch from Alex Concha: add control in admin pages to avoid 
+                            possible XSS derived from CSRF attacks, if the users store
+                                    the form with the "injected" bad values.
-      2007-01-31
-            - Version 2.1: modified and tested with WP 2.1, WP 2.0, WP 1.5 and PHP 4.3 and PHP 5.2.
@@ -174 +178 @@
-
-function wp_cache_manager() {
-
-
+
+
+
+
-      echo '<div class="wrap">';
-      echo "<h2>WP-Cache Manager</h2>\n";
-
+ && $valid_nonce
-            unlink($wp_cache_config_file);
-            echo '<strong>Configuration file changed, some values might be wrong. Load the page again from the "Options" menu to reset them.</strong>';
@@ -197 +203 @@
-      }
-
-
-
-
-
+
+
+
+
+
+
-      }
-
@@ -213 +221 @@
-            echo '<div class="submit"><input type="submit" value="Enable it" /></div>';
-      }
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-
@@ -239 +248 @@
-      echo '<input type="hidden" name="wp_restore_config" />';
-      echo '<div class="submit"><input type="submit" id="deletepost" value="Restore default configuration" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-      echo '</fieldset>';
@@ -245 +255 @@
-
-function wp_cache_edit_max_time () {
-
-
-
+, $valid_nonce
+
+ && $valid_nonce
-            $max_time = (int)$_REQUEST['wp_max_time'];
-            if ($max_time > 0) {
@@ -258 +268 @@
-      echo "<input type=\"text\" name=\"wp_max_time\" value=\"$cache_max_time\" />";
-      echo '<div class="submit"><input type="submit" value="Change expiration" /></div>';
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
-}
-
-function wp_cache_edit_rejected_ua() {
-
+, $valid_nonce
-
-      if (!function_exists('apache_request_headers')) return;
-
-
-
-
-
+
+
-            wp_cache_replace_line('^ *\$cache_rejected_user_agent', "\$cache_rejected_user_agent = $text;", $wp_cache_config_file);
-            $cache_rejected_user_agent = $array;
-      }
-
@@ -285 +301 @@
-      echo '<textarea name="wp_rejected_user_agent" cols="40" rows="4" style="width: 70%; font-size: 12px;" class="code">';
-      foreach ($cache_rejected_user_agent as $ua) {
-"$ua
+wp_specialchars($ua) . "
-      }
-      echo '</textarea> ';
-      echo '<div class="submit"><input type="submit" value="Save UA strings" /></div>';
+      wp_nonce_field('wp-cache');
-      echo '</form>';
-      echo "</fieldset>\n";
@@ -295 +312 @@
-
-function wp_cache_edit_rejected() {
-
-
-
-
-
-
+
+
+
+
-            wp_cache_replace_line('^ *\$cache_rejected_uri', "\$cache_rejected_uri = $text;", $wp_cache_config_file);
-            $cache_rejected_uri = $array;
-      }
-
@@ -311 +325 @@
-      echo '<textarea name="wp_rejected_uri" cols="40" rows="4" style="width: 70%; font-size: 12px;" class="code">';
-      foreach ($cache_rejected_uri as $file) {
-"$file
+wp_specialchars($file) . "
-      }
-      echo '</textarea> ';
-      echo '<div class="submit"><input type="submit" value="Save strings" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-}
-
-function wp_cache_edit_accepted() {
-
-
-
-
-
-
+
+
+
+
-            wp_cache_replace_line('^ *\$cache_acceptable_files', "\$cache_acceptable_files = $text;", $wp_cache_config_file);
-            $cache_acceptable_files = $array;
-      }
-
@@ -335 +347 @@
-      echo '<textarea name="wp_accepted_files" cols="40" rows="8" style="width: 70%; font-size: 12px;" class="code">';
-      foreach ($cache_acceptable_files as $file) {
-"$file
+wp_specialchars($file) . "
-      }
-      echo '</textarea> ';
-      echo '<div class="submit"><input type="submit" value="Save files" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-}
@@ -504 +517 @@
-
-function wp_cache_files() {
-
+, $valid_nonce
-
-      if ( '/' != substr($cache_path, -1)) {
@@ -510 +523 @@
-      }
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
-      }
-      if(isset($_REQUEST['wp_list_cache'])) {
@@ -565 +579 @@
-                              echo '<input type="hidden" name="wp_delete_cache_file" value="'.preg_replace("/^(.*)\.meta$/", "$1", $file).'" />';
-                              echo '<div class="submit"><input id="deletepost" type="submit" value="Remove" /></div>';
+                              wp_nonce_field('wp-cache');
-                              echo "</form></td></tr>\n";
-                        }
@@ -579 +594 @@
-      echo '<input type="hidden" name="wp_list_cache" />';
-      echo '<div class="submit"><input type="submit" value="Delete expired" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-
@@ -585 +601 @@
-      echo '<input type="hidden" name="wp_delete_cache" />';
-      echo '<div class="submit"><input id="deletepost" type="submit" value="Delete cache" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-

wp-cache/trunk/wp-cache.php

@@ -4 +4 @@
-Plugin URI: http://mnm.uib.es/gallir/wp-cache-2/
-Description: Very fast cache module. It's composed of several modules, this plugin can configure and manage the whole system. Once enabled, go to "Options" and select "WP-Cache".
-
+.1
-Author: Ricardo Galli Granada
-Author URI: http://mnm.uib.es/gallir/
@@ -26 +26 @@
-
-/* Changelog
+      2007-03-23
+            - Version 2.1.1: Patch from Alex Concha: add control in admin pages to avoid 
+                            possible XSS derived from CSRF attacks, if the users store
+                                    the form with the "injected" bad values.
-      2007-01-31
-            - Version 2.1: modified and tested with WP 2.1, WP 2.0, WP 1.5 and PHP 4.3 and PHP 5.2.
@@ -174 +178 @@
-
-function wp_cache_manager() {
-
-
+
+
+
+
-      echo '<div class="wrap">';
-      echo "<h2>WP-Cache Manager</h2>\n";
-
+ && $valid_nonce
-            unlink($wp_cache_config_file);
-            echo '<strong>Configuration file changed, some values might be wrong. Load the page again from the "Options" menu to reset them.</strong>';
@@ -197 +203 @@
-      }
-
-
-
-
-
+
+
+
+
+
+
-      }
-
@@ -213 +221 @@
-            echo '<div class="submit"><input type="submit" value="Enable it" /></div>';
-      }
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-
@@ -239 +248 @@
-      echo '<input type="hidden" name="wp_restore_config" />';
-      echo '<div class="submit"><input type="submit" id="deletepost" value="Restore default configuration" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-      echo '</fieldset>';
@@ -245 +255 @@
-
-function wp_cache_edit_max_time () {
-
-
-
+, $valid_nonce
+
+ && $valid_nonce
-            $max_time = (int)$_REQUEST['wp_max_time'];
-            if ($max_time > 0) {
@@ -258 +268 @@
-      echo "<input type=\"text\" name=\"wp_max_time\" value=\"$cache_max_time\" />";
-      echo '<div class="submit"><input type="submit" value="Change expiration" /></div>';
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
-}
-
-function wp_cache_edit_rejected_ua() {
-
+, $valid_nonce
-
-      if (!function_exists('apache_request_headers')) return;
-
-
-
-
-
+
+
-            wp_cache_replace_line('^ *\$cache_rejected_user_agent', "\$cache_rejected_user_agent = $text;", $wp_cache_config_file);
-            $cache_rejected_user_agent = $array;
-      }
-
@@ -285 +301 @@
-      echo '<textarea name="wp_rejected_user_agent" cols="40" rows="4" style="width: 70%; font-size: 12px;" class="code">';
-      foreach ($cache_rejected_user_agent as $ua) {
-"$ua
+wp_specialchars($ua) . "
-      }
-      echo '</textarea> ';
-      echo '<div class="submit"><input type="submit" value="Save UA strings" /></div>';
+      wp_nonce_field('wp-cache');
-      echo '</form>';
-      echo "</fieldset>\n";
@@ -295 +312 @@
-
-function wp_cache_edit_rejected() {
-
-
-
-
-
-
+
+
+
+
-            wp_cache_replace_line('^ *\$cache_rejected_uri', "\$cache_rejected_uri = $text;", $wp_cache_config_file);
-            $cache_rejected_uri = $array;
-      }
-
@@ -311 +325 @@
-      echo '<textarea name="wp_rejected_uri" cols="40" rows="4" style="width: 70%; font-size: 12px;" class="code">';
-      foreach ($cache_rejected_uri as $file) {
-"$file
+wp_specialchars($file) . "
-      }
-      echo '</textarea> ';
-      echo '<div class="submit"><input type="submit" value="Save strings" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-}
-
-function wp_cache_edit_accepted() {
-
-
-
-
-
-
+
+
+
+
-            wp_cache_replace_line('^ *\$cache_acceptable_files', "\$cache_acceptable_files = $text;", $wp_cache_config_file);
-            $cache_acceptable_files = $array;
-      }
-
@@ -335 +347 @@
-      echo '<textarea name="wp_accepted_files" cols="40" rows="8" style="width: 70%; font-size: 12px;" class="code">';
-      foreach ($cache_acceptable_files as $file) {
-"$file
+wp_specialchars($file) . "
-      }
-      echo '</textarea> ';
-      echo '<div class="submit"><input type="submit" value="Save files" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-}
@@ -504 +517 @@
-
-function wp_cache_files() {
-
+, $valid_nonce
-
-      if ( '/' != substr($cache_path, -1)) {
@@ -510 +523 @@
-      }
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
-      }
-      if(isset($_REQUEST['wp_list_cache'])) {
@@ -565 +579 @@
-                              echo '<input type="hidden" name="wp_delete_cache_file" value="'.preg_replace("/^(.*)\.meta$/", "$1", $file).'" />';
-                              echo '<div class="submit"><input id="deletepost" type="submit" value="Remove" /></div>';
+                              wp_nonce_field('wp-cache');
-                              echo "</form></td></tr>\n";
-                        }
@@ -579 +594 @@
-      echo '<input type="hidden" name="wp_list_cache" />';
-      echo '<div class="submit"><input type="submit" value="Delete expired" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-
@@ -585 +601 @@
-      echo '<input type="hidden" name="wp_delete_cache" />';
-      echo '<div class="submit"><input id="deletepost" type="submit" value="Delete cache" /></div>';
+      wp_nonce_field('wp-cache');
-      echo "</form>\n";
-