Ticket #727 (assigned enhancement)

Opened 7 months ago

Last modified 5 months ago

combine link_summary() and get_link_summary()

Reported by: Ammaletu Assigned to: GrafZahl (accepted)
Priority: low Component: link-summarizer
Severity: minor Keywords:
Cc: johannes@bolarus.de

Description

I wanted to change some details of the plugin (more to come if you like) and, to make these changes easier, started with combining the two functions link_summary() and get_link_summary() which were virtually equal. I've attached the changed plugin file, based on the current development version. Both functions now use lnsum_generate_link_summary() to get their output. If you want to incorporate this into your plugin, you might want to check my use of tab characters (I'm using spaces usually).

Attachments

link-summarizer-combined-functions.php (14.3 kB) - added by Ammaletu on 12/01/07 18:34:30.
plugin with new function lnsum_generate_link_summary
link-summarizer-further-changes.php (15.3 kB) - added by Ammaletu on 12/13/07 00:19:28.
plugin with further changes, see comment

Change History

12/01/07 18:34:30 changed by Ammaletu

  • attachment link-summarizer-combined-functions.php added.

plugin with new function lnsum_generate_link_summary

12/01/07 18:41:20 changed by Ammaletu

  • cc changed from jr@johannes-ruthenberg.de to johannes@bolarus.de.

12/13/07 00:19:28 changed by Ammaletu

  • attachment link-summarizer-further-changes.php added.

plugin with further changes, see comment

12/13/07 00:20:38 changed by Ammaletu

I did some further changes (based on my previous change):
- accepts both '...' and "..." as attribute delimiters (I didn't filter for wrong cases like '...", they are accepted as well)
- doesn't copy the ID attribute of links (because it's supposed to be unique)
- if the link has no title attribute and the URL is used as new link text, the original link text is used as title attribute

01/18/08 11:05:40 changed by GrafZahl

  • status changed from new to assigned.

02/09/08 14:06:49 changed by GrafZahl

The suggestions on combining the two functions into one and call it via wrapper functions has been incorporated and will be contained in the next release (1.5). For your suggestions regarding link attributes I will have to take a deeper look at them. Maybe they'll be also included into 1.5